Review a code diff and rank the findings
Reviews a pasted diff the way a careful colleague would and ranks at most eight findings from blocking to nitpick, each with a suggested fix.
Task:
Review the diff below and rank your findings from blocking to nitpick.
Context:
The change is in [language and framework] and it is meant to [purpose of the change]. The reviewers on my team care most about [review priorities].
Rules:
- Read the whole diff before you write the first finding.
- Judge correctness, edge cases, readability, tests and anything that could harm users or data.
- Quote the changed line for each finding and suggest a fix of at most five lines.
- Say so when a finding depends on code outside the diff, and name the file I should look at.
- Never ask me for secrets or keys. If the diff contains one, flag it as blocking and tell me to rotate it.
Result:
At most eight findings in a numbered list, each labeled blocking, should fix or nitpick. Start with one sentence stating whether you would approve the change.
Material:
[paste the diff here]